COMP opcode with indicators

[hockeygrl]

Ok, I'm converting a program flow written in RPG using COMP opcode into RPGIV. Code is below:

	   
           KEY	CHAIN	       FILEA	       	10
	  *IN10	DOWNE	       '1'
	  VAR1	COMP	       VAR2		2727
      27VAR3	COMP	        '0'		        27
      27VAR4	COMP        	'D'		2727
     N27KEY       READE	       FILEA		10
     N27	        ENDDO

The confusing part for me is the lines of code that uses COMPARE. The way I understand is that this is what will happen.

1) If VAR1 and VAR2 are not equal, *IN27 is *ON.
2) The second compare of VAR3 will be processed if *IN27 is *ON. If VAR3 is equal to '0', *IN27 = *ON. Otherwise, *IN27 = *OFF.
3) If *IN27 = *ON, VAR4 is compared to 'D'. If VAR4 = 'D', *IN27 is switched *OFF. Another round of READE is done and VAR4 checking is skipped.

If my assumptions are correct, I plan to convert the logic into the following:

KEY  CHAIN  FILEA   
DoW  Not %EoF(FILEA)

If VAR1 <> VAR2
	If VAR3 = 0 and VAR4 <> 'D'
		...several more statements
	EndIf
EndIf
KEY  ReadE  FILEA   
Enddo

Any feedback is greatly appreciated. Thanks!

[kitvb1]

Re: COMP opcode with indicators

Welcome back after such a long time... or have you just been lurking?

Check out this thread http://www.code400.com/forum/showthread.php?t=6631

A few of the good folk here have come up with some good solutions (i.e. various ways) to answer exactly the same question.

[GLS400]

Re: COMP opcode with indicators

Hi hockeygrl:

This is my version:

            
dow var1<> var2 and var3 = 0 and var4 <> 'D' 
        or not %found(filea);
             reade key filea;
enddo;

This statement from the origional code says if all of the above is false do the read:

[COLOR=blue]N27[/COLOR]KEY       READE           FILEA        10

Best of Luck
GLS

[MichaelCatalani]

Re: COMP opcode with indicators

Hi hockeygrl:

This is my version:

            
dow var1<> var2 and var3 = 0 and var4 <> 'D' 
        or not %found(filea);
             reade key filea;
enddo;

I think your or not %found( filea ) should be and %found( filea )

as in:


dow %found( filea ) and var1 <> var2 and var3 = 0
and var4 <> 'D' ;

As a matter of standard, I put the file condition in my expression first. Also, I would convert to the setll and reade instead of the chain since we are performing another reade in the loop, but this is also just a matter of preferance.

setll ( key ) filea;
reade ( key ) filea;

dow %found( filea ) and var1 <> var2 and var3 = 0 
                    and var4 <> 'D' ;
  //  do stuff

    reade key filea;
enddo;

[GLS400]

Re: COMP opcode with indicators

I think your or not %found( filea ) should be and %found( filea )

Well you know mike there's a word for that.......

OOPS

Good catch
GLS

[hockeygrl]

Re: COMP opcode with indicators

Welcome back after such a long time... or have you just been lurking?

Haha! I haven't been able to check out any AS400 forums really for a long time because of work. Besides, most technical issues in RPGILE, I am able to either just review the ibm manual or ask my colleagues about it. However, old-style RPG such as conversion of COMP opcode is a different matter. Just got more confused reading the manuals.

Thanks for the link btw. It most certainly helped since my problem really is if my understanding of the COMP codes were correct.

I'll take into account all the suggestions with the way FILEA is read. Thanks you guys!

Thank God I still remember my login information even if it's been years!